-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
chore: save compiled output for test suites #4251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: save compiled output for test suites #4251
Conversation
It'd be nice not to have another flag. Could we just generate them unless |
Good suggestion for just generate it for failing test. |
Right now it is compiled twice if we save the output to file. Wonder is it okay if I save to file during the require.extension? |
The require hook wouldn't know whether the test failed, would it? I think removing the existing console.log of the compiled code for failing tests makes sense. |
Yea it wouldn't know |
The reason I added a flag, is that without the flag, it would compile the code twice, once for require extensions, once for saving to file, and probably thrice when console out for failing case |
f3cc6b5
to
6141b2b
Compare
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
6141b2b
to
ac9e977
Compare
cab6c6b
to
b29dcab
Compare
With the idea of having ESM only for Svelte 4, I'm wondering how much long-livety this change this has. But all checks pass and changes seem to look good to me, so maybe it doesn't hurt. Will wait for other maintainers to chime before deciding. |
return name[0].toUpperCase() + name.slice(1); | ||
} | ||
|
||
export function setCompileOptions(_compileOptions: CompileOptions) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should these methods be named with the underscore convention like set_compile_options
?
Closing, as compiled output is saved to disk on the |
Unifying the test helper to save the compiled output for:
use the
register.extension
to also save the compiled output to filesystem.Updated 2022-10-14
register.extension
in the test, we will record the compiled output in a cache