Skip to content

Assignment anywhere #3532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Assignment anywhere #3532

wants to merge 3 commits into from

Conversation

hbendev
Copy link

@hbendev hbendev commented Sep 7, 2019

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests tests with npm test or yarn test)

This fixes issue #3512

@codecov-io
Copy link

codecov-io commented Sep 7, 2019

Codecov Report

Merging #3532 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3532   +/-   ##
=======================================
  Coverage   50.25%   50.25%           
=======================================
  Files           1        1           
  Lines         197      197           
=======================================
  Hits           99       99           
  Misses         98       98

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41f5961...6abc8c6. Read the comment docs.

@Rich-Harris
Copy link
Member

Thank you! This is a great PR — I didn't believe there was a fix as straightforward as this one.

As it happened I was also working on a PR for this separately (#3533). It doesn't have the forehead-smacking elegance of this one, but it allows us to remove about 90 LOC from the compiler, and will handle weird edge cases involving destructuring assignments. So I'm going to close this in favour of that one — but thanks anyway 🍻

@Rich-Harris Rich-Harris closed this Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants