only use setAttribute with SVG spread props #3531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should also fix #2732 |
|
I guess the obvious question is: So there aren't any boolean attributes in SVG? If there aren't, yeah this makes a lot of sense. |
|
Is #1708 also the same issue? It seems like it might be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3522. Not sure why it took so long for this solution to occur to me (apologies if anyone had already suggested it) — all we need to do is guarantee that SVG spread attributes are only ever set with
setAttribute, and we're good.The test here is harmless, but also useless — JSDOM doesn't error when you try to set readonly properties, and I can't be bothered to raise an issue.