Skip to content

error on contextual stores, for now #2103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/compile/nodes/shared/Expression.ts
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,16 @@ export default class Expression {
const { name, nodes } = flattenReference(node);

if (scope.has(name)) return;

if (globalWhitelist.has(name) && !component.var_lookup.has(name)) return;

if (name[0] === '$' && template_scope.names.has(name.slice(1))) {
component.error(node, {
code: `contextual-store`,
message: `Stores must be declared at the top level of the component (this may change in a future version of Svelte)`
});
}

if (template_scope.is_let(name)) {
if (!function_expression) {
dependencies.add(name);
Expand Down
76 changes: 76 additions & 0 deletions test/runtime/samples/store-contextual/_config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
import { writable } from '../../../../store.js';

const todos = [
writable({ done: false, text: 'write docs' }),
writable({ done: false, text: 'implement contextual stores' }),
writable({ done: false, text: 'go outside' })
];

export default {
error: `Stores must be declared at the top level of the component (this may change in a future version of Svelte)`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the other values in this object don't do anything when error is present? So we can just remove error once this is implemented?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exactly, yep


props: {
todos
},

html: `
<label>
<input type=checkbox>
[todo] write docs
</label>

<label>
<input type=checkbox>
[todo] implement contextual stores
</label>

<label>
<input type=checkbox>
[todo] go outside
</label>
`,

async test({ assert, component, target, window }) {
const inputs = target.querySelectorAll('input');
const change = new window.MouseEvent('change');

inputs[1].checked = true;
await inputs[1].dispatchEvent(change);

assert.htmlEqual(target.innerHTML, `
<label>
<input type=checkbox>
[todo] write docs
</label>

<label>
<input type=checkbox>
[done] implement contextual stores
</label>

<label>
<input type=checkbox>
[todo] go outside
</label>
`);

await todos[0].update(todo => ({ done: !todo.done, text: todo.text }));

assert.htmlEqual(target.innerHTML, `
<label>
<input type=checkbox>
[done] write docs
</label>

<label>
<input type=checkbox>
[done] implement contextual stores
</label>

<label>
<input type=checkbox>
[todo] go outside
</label>
`);
}
};
6 changes: 6 additions & 0 deletions test/runtime/samples/store-contextual/main.svelte
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{#each todos as todo}
<label>
<input type=checkbox on:change={e => todo.update(t => ({ done: e.target.checked, text: t.text }))}>
{$todo.done ? '[done]' : '[todo]'} {$todo.text}
</label>
{/each}