error on contextual stores, for now #2103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2103 +/- ##
======================================
Coverage 100% 100%
======================================
Files 1 1
Lines 49 49
======================================
Hits 49 49Continue to review full report at Codecov.
|
Conduitry
reviewed
Feb 19, 2019
| ]; | ||
|
|
||
| export default { | ||
| error: `Stores must be declared at the top level of the component (this may change in a future version of Svelte)`, |
There was a problem hiding this comment.
I assume the other values in this object don't do anything when error is present? So we can just remove error once this is implemented?
Conduitry
approved these changes
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #2016. Contextual stores present some difficulties, and I think it'd be better to figure those out in a 3.1 release rather than hold up 3.0