-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix: Add check for builtin custom elements in set_custom_element_data
#16592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add check for builtin custom elements in set_custom_element_data
#16592
Conversation
🦋 Changeset detectedLatest commit: 2117a15 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thank you, that makes sense. For a test, you can e.g. enhance the one you created back in #15086: Add a |
@dummdidumm Added the test case! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint
Fixes #16591
This PR introduces a check for builtin custom elements (
is
attribute) inside theset_custom_element_data
helper in order to correctly set properties that have a setter.I would like to add tests but I am not familiar with the codebase and wasn't able to find the correct path.