Make passing options to component optional #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 92.14% (diff: 100%)@@ master #146 diff @@
==========================================
Files 52 52
Lines 1423 1528 +105
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1303 1408 +105
Misses 120 120
Partials 0 0
|
|
When is this necessary? If you're instantiating a component yourself you have to supply |
|
No idea where my brain was when I thought this would be a good idea... |
Since we have separated mount, you can create a component without |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #145 I noticed that creating a component without passing an empty options object was not possible. This PR is fixing that.