Skip to content

breaking: remove deep reactivity from non-bindable props #12484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Jul 17, 2024

This reverts parts of #11804. Specifically, if we have a prop is not defined as $bindable, then we don't proxy the fallback value, nor do we proxy any mutations to that prop. We now specifically only make props that have been marked as $bindable deeply reactive.

Copy link

changeset-bot bot commented Jul 17, 2024

🦋 Changeset detected

Latest commit: 167e77d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit ea22840 into main Jul 17, 2024
9 checks passed
@Rich-Harris Rich-Harris deleted the non-bound-prop-reactivity branch July 17, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants