Skip to content

breaking: warn on quotes single-expression attributes in runes mode #12479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 17, 2024

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Jul 17, 2024

In a future version, that will mean things are getting stringified, which is a departure from how things work today, therefore a warning first.
Related to #7925 (but not yet closing that issue; we should only do that once we actually have changed the behavior)

Solved by adjusting the AST so that it's now { type: 'Attribute', value: true | ExpressionTag | Array<ExpressionTag | Text>, ... }

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

In a future version, that will mean things are getting stringified, which is a departure from how things work today, therefore a warning first.
Related to #7925
Copy link

changeset-bot bot commented Jul 17, 2024

🦋 Changeset detected

Latest commit: 372c64b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants