-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
breaking: warn on quotes single-expression attributes in runes mode #12479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (i.e. don't wrap in an array)
In a future version, that will mean things are getting stringified, which is a departure from how things work today, therefore a warning first. Related to #7925
🦋 Changeset detectedLatest commit: 372c64b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Rich-Harris
reviewed
Jul 17, 2024
Rich-Harris
reviewed
Jul 17, 2024
Rich-Harris
reviewed
Jul 17, 2024
Rich-Harris
reviewed
Jul 17, 2024
Rich-Harris
reviewed
Jul 17, 2024
packages/svelte/tests/validator/samples/attribute-quoted/warnings.json
Outdated
Show resolved
Hide resolved
Rich-Harris
reviewed
Jul 17, 2024
packages/svelte/tests/validator/samples/attribute-quoted/warnings.json
Outdated
Show resolved
Hide resolved
Rich-Harris
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a future version, that will mean things are getting stringified, which is a departure from how things work today, therefore a warning first.
Related to #7925 (but not yet closing that issue; we should only do that once we actually have changed the behavior)
Solved by adjusting the AST so that it's now
{ type: 'Attribute', value: true | ExpressionTag | Array<ExpressionTag | Text>, ... }
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint