Skip to content

fix: allow trailing comments on functions #12469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: allow trailing comments on functions #12469

wants to merge 1 commit into from

Conversation

paoloricciuti
Copy link
Member

Svelte 5 rewrite

Closes #12466

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jul 17, 2024

🦋 Changeset detected

Latest commit: 078746a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

Thanks, but I think this is the wrong fix - the trailing comment shouldn't be there in the first place IMO. Currently working on that issue aswell (assigned myself), PR soon.

@paoloricciuti
Copy link
Member Author

Thanks, but I think this is the wrong fix - the trailing comment shouldn't be there in the first place IMO. Currently working on that issue aswell (assigned myself), PR soon.

WDYM the issue has a comment in the body function...that should be allowed right? Also this PR that got merged 2 days ago #11866 allowed comments in mustache tags

@dummdidumm
Copy link
Member

dummdidumm commented Jul 17, 2024

I opened #12471 as an alternative - both fixes have valid arguments in their favor. If we want to keep all comment nodes, even if they are sometimes at weird/invalid positions, we gotta go with this one. Else we need to go with the other one. If we want more correct trailing commas but preserved, we need a third variant, which would also take into account trailing comments that are after a line break.
Edit: Made that third variant work in the other PR, which through that also fixes some adjacent bugs around trailing comments being inserted in the wrong places. I therefore think we should go with the other PR.

@Rich-Harris
Copy link
Member

Merged #12471, so I'll close this one, but thanks for looking into it — comment stuff is always a nightmare

@paoloricciuti
Copy link
Member Author

Merged #12471, so I'll close this one, but thanks for looking into it — comment stuff is always a nightmare

Yeah no problem at all that's a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

svelte 5 : Attribute values containing {...} must be enclosed in quote marks, unless the value only contains the expression
3 participants