fix: allow trailing comments on functions

[paoloricciuti]

Svelte 5 rewrite

Closes #12466

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

• It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
• Prefix your PR title with feat:, fix:, chore:, or docs:.
• This message body should clearly illustrate what problems it solves.
• Ideally, include a test that fails without this PR but passes with it.

Tests and linting

• Run the tests with pnpm test and lint the project with pnpm lint

[changeset-bot]

🦋 Changeset detected

Latest commit: 078746a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
svelte	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[dummdidumm]

Thanks, but I think this is the wrong fix - the trailing comment shouldn't be there in the first place IMO. Currently working on that issue aswell (assigned myself), PR soon.

[paoloricciuti]

Thanks, but I think this is the wrong fix - the trailing comment shouldn't be there in the first place IMO. Currently working on that issue aswell (assigned myself), PR soon.

WDYM the issue has a comment in the body function...that should be allowed right? Also this PR that got merged 2 days ago #11866 allowed comments in mustache tags

[dummdidumm]

I opened #12471 as an alternative - both fixes have valid arguments in their favor. If we want to keep all comment nodes, even if they are sometimes at weird/invalid positions, we gotta go with this one. Else we need to go with the other one. If we want more correct trailing commas but preserved, we need a third variant, which would also take into account trailing comments that are after a line break.
Edit: Made that third variant work in the other PR, which through that also fixes some adjacent bugs around trailing comments being inserted in the wrong places. I therefore think we should go with the other PR.

[Rich-Harris]

Merged #12471, so I'll close this one, but thanks for looking into it — comment stuff is always a nightmare

[paoloricciuti]

Merged #12471, so I'll close this one, but thanks for looking into it — comment stuff is always a nightmare

Yeah no problem at all that's a better solution.