-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[WIP] Simplify everything #1173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tests passing. Now to tidy up the mess I just made |
Codecov Report
@@ Coverage Diff @@
## master #1173 +/- ##
==========================================
- Coverage 91.75% 91.73% -0.03%
==========================================
Files 127 127
Lines 4572 4560 -12
Branches 1495 1494 -1
==========================================
- Hits 4195 4183 -12
- Misses 159 160 +1
+ Partials 218 217 -1
Continue to review full report at Codecov.
|
Think this is probably good to squash and merge. Some follow-up work:
|
See #1122. Lots still to do, and this branch is currently rather messy, but I'm starting to think this will be a big win.