Skip to content

Conversation

Rich-Harris
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented May 13, 2024

⚠️ No Changeset found

Latest commit: 8aa7e04

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@trueadm
Copy link
Contributor

trueadm commented May 13, 2024

Should we also do TS and Prettier?

@Rich-Harris
Copy link
Member Author

Nah, I like having auto-formatting and it's useful to try out type-related stuff. It's only ESLint that I have absolutely zero patience for

@Rich-Harris Rich-Harris merged commit faa2e93 into main May 13, 2024
@Rich-Harris Rich-Harris deleted the exclude-playground-from-eslint branch May 13, 2024 21:34
@@ -45,6 +45,7 @@ export default [
'sites/svelte-5-preview/**',
// wasn't checked previously, reenable at some point
'sites/svelte.dev/**',
'playgrounds/demo/src/**',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've added this to “wasn't checked previously, reenable at some point” section. Shouldn't it be added above that comment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah good catch. it's really only the one line that the comment should apply to (i.e. not tmp/**) — reordered in 50a9020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants