Skip to content

fix: execute sole static script tag #11095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2024
Merged

fix: execute sole static script tag #11095

merged 3 commits into from
Apr 9, 2024

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Apr 8, 2024

  • take into account that template could consist of a single script tag, for which querySelectorAll('script') would yield false negatives
  • add test to ensure that we don't execute script tags inside @html tags next to static script tags

fixes #11082

Had to move one test because jsdom does wrongfully eagerly execute scripts, which the browser does not do when it's inserted like we do.
Should be merged after #11099 because it likely needs to move the test in there to the runtime-browser-suite, too.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

- take into account that template could consist of a single script tag, for which querySelectorAll('script') would yield false negatives
- add test to ensure that we don't execute script tags inside `@html` tags next to static script tags

fixes #11082
Copy link

changeset-bot bot commented Apr 8, 2024

🦋 Changeset detected

Latest commit: bc7e127

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: <script> tag doesn't load conditionally
2 participants