-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix: run onDestroy
cleanup during SSR
#10297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: a3a3fc1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
onDestroy
cleanup during SSR
Dusted this off, implemented the fix and wondered why it still fails - turns out we're running the SSR tests in DOM mode, too. I had to add a separate vitest config to run the tests in a "real" server environment - couldn't find a better way to achieve this. Makes running the tests a bit more tedious and slower which is a shame, and given that they all run just fine in both environments we could scope this "real SSR environment" to a few specific tests only (for example only run the browser environemtn ssr tests in it). Open to suggestions. |
Fixes #10296
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint