Svelte 5: next43 -> next44: can't convert symbol to string #10372

dm-de · 2024-02-01T19:37:08Z

Describe the bug

Possible related to this: #10343

This adds new bug to Svelte 5

Reproduction

Click on any button - and you get many errors

See Item.svelte HTML comment. This line produce error.

LINK

Logs

Uncaught TypeError: can't convert symbol to string

readonly_error playground:output:335
proxy playground:output:86
set playground:output:241
foo playground:output:3415
batch_inspect playground:output:558
on_click playground:output:3370
handle_event_propagation playground:output:2279

System Info

running Svelte compiler version 5.0.0-next.44

Severity

blocking an upgrade

The readonly dev time validation results in false-negative object equality checks: The original object is proxified and thus comparisons could be between the unproxified and proxified version, which will always return false. Fixes #10372 There's also the problem that an object could be passed into a component but then passed upwards into shared state. At that point, it should no longer be readonly, but it's not possible to statically analyze these points. Fixes #10372 Lastly, the each block logic mutates an internal array and that also throws errors with the readonly logic. Fixes #10037

evnix · 2024-02-19T09:07:49Z

I upgraded from next.37 to next.59

and got the same error,

as mentioned, we can't do an upgrade

* fix: remove readonly validation The readonly dev time validation results in false-negative object equality checks: The original object is proxified and thus comparisons could be between the unproxified and proxified version, which will always return false. Fixes #10372 There's also the problem that an object could be passed into a component but then passed upwards into shared state. At that point, it should no longer be readonly, but it's not possible to statically analyze these points. Fixes #10372 Lastly, the each block logic mutates an internal array and that also throws errors with the readonly logic. Fixes #10037 * reinstate tests * track ownership of state and mutations * working? * remove old changeset * tidy * error * simplify * fix * fix * fix * tidy * make it a warning * rename test * remove unused test * update tests * slap ts-expect-error everywhere, because its too finicky otherwise * oops * oh no the hall monitor is here * only call add_owner in dev * only owners can transfer ownership * simplify * fixes * tidy up * fix type error * while we're at it * rename file * rename functions * add some comments * move ownership checking logic * ugh eslint * more detailed message * only add filename in dev * comment * update tests * move more code * undo change to sourcemap tests * allow proxy to have multiple owners * use SignalDebug * i was doing this all wrong * tidy up * implement inheritance * fix * tidy up * update filename stuff * changeset --------- Co-authored-by: Simon Holthausen <[email protected]> Co-authored-by: Rich Harris <[email protected]>

dummdidumm added this to the 5.0 milestone Feb 2, 2024

dummdidumm added the bug label Feb 2, 2024

dummdidumm self-assigned this Feb 2, 2024

dummdidumm mentioned this issue Feb 2, 2024

fix: remove readonly validation #10378

Closed

5 tasks

Rich-Harris linked a pull request Feb 20, 2024 that will close this issue

fix: stack-trace-based readonly validation #10464

Merged

11 tasks

Rich-Harris closed this as completed in #10464 Feb 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Svelte 5: next43 -> next44: can't convert symbol to string #10372

Svelte 5: next43 -> next44: can't convert symbol to string #10372

dm-de commented Feb 1, 2024 •

edited

Loading

evnix commented Feb 19, 2024

Svelte 5: next43 -> next44: can't convert symbol to string #10372

Svelte 5: next43 -> next44: can't convert symbol to string #10372

Comments

dm-de commented Feb 1, 2024 • edited Loading

Describe the bug

Reproduction

Logs

System Info

Severity

evnix commented Feb 19, 2024

dm-de commented Feb 1, 2024 •

edited

Loading