fix: correct scroll position if needed #343
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason that escapes me Chrome ignores the `scroll-margin-top` property. It's possible to fix it using JS even thought that's not ideal. fixes #273
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
it's visible on deployment too. example: jump between "events" and "attributes and props" |
|
you know i couldn't possibly rest until i'd solved this for real :) turns out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason that escapes me Chrome ignores the
scroll-margin-topproperty. It's possible to fix it using JS even though that's not ideal. fixes #273 (the logic is taken from #96 where it was removed)This was a bit jumpy locally in dev mode at times (tested on the "Basic markup" page), let's see how it works when deployed.
If we don't find a better solution fast then I'd merge this anyway but keep the related issue open until we find a proper non-JS fix. This is still better than not scrolling the headers into view.