Skip to content

Headings don't respect scroll padding in Chrome #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Rich-Harris opened this issue Oct 7, 2024 · 0 comments · Fixed by #346
Closed

Headings don't respect scroll padding in Chrome #273

Rich-Harris opened this issue Oct 7, 2024 · 0 comments · Fixed by #346
Labels
docs (design)
Milestone
launch

Comments

@Rich-Harris
Copy link
Member

If I click on the link icon next to a header in Firefox, the page scrolls such that the header sits neatly below the nav bar. In Chrome, it's hidden by the nav bar.
@Rich-Harris Rich-Harris added this to the launch milestone Oct 7, 2024
dummdidumm added a commit that referenced this issue Oct 11, 2024
@dummdidumm
fix: correct scroll position if needed
b527541 
For some reason that escapes me Chrome ignores the `scroll-margin-top` property. It's possible to fix it using JS even thought that's not ideal. fixes #273
@dummdidumm dummdidumm mentioned this issue Oct 11, 2024
Closed
@Rich-Harris Rich-Harris mentioned this issue Oct 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs (design)
Projects
None yet
Milestone
launch
1 participant
@Rich-Harris