feat: Skip type injection if template uses TypeScript #440
+8,589
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 136e6e0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Pull Request Test Coverage Report for Build 6965825787
💛 - Coveralls |
baseballyama
force-pushed
the
feat/template-ts
branch
from
ff44961 to
a15002b
Compare
baseballyama
commented
Nov 23, 2023
| @@ -922,6 +923,9 @@ function buildProcessExpressionForExpression( | |||
| typing: string | null, | |||
| ): (expression: ESTree.Expression) => ScriptLetCallback<ESTree.Expression>[] { | |||
There was a problem hiding this comment.
Should I use TSESTree here? Write ESTree.Expression | TSESTree.Expression everytime is hassle, and since the type information is only needed in a few places, I thought it would be okay to leave the type information as it is. What do you think?
There was a problem hiding this comment.
I think it's OK to leave it as is for now 👍. I think that acorn-typescript nodes and TSESTree are not compatible, so just using TSESTree will not be a complete solution.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Discussion point:
I think somehow we can avoid to generate injection types if there is type information but I couldn't find a way. If we can do this, this is better in terms of performance.