Skip to content

fix: parsing error when <script> has attribute with empty value #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 16, 2022
Merged

fix: parsing error when <script> has attribute with empty value #220

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4423821
fix: parsing error when `<script>` has attribute with empty value
ota-meshi Sep 16, 2022
2ab32e3
Create sweet-boats-exist.md
ota-meshi Sep 16, 2022
d8fe76f
fix for empty text and add quote tests
ota-meshi Sep 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/sweet-boats-exist.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"svelte-eslint-parser": patch
---

fix: parsing error when `<script>` has attribute with empty value
11 changes: 11 additions & 0 deletions src/parser/html.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,17 @@ function parseAttributeValue(
index,
};
}
if (valueFirstChar === quote) {
Copy link
Collaborator

@JounQin JounQin Sep 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wil id="'"(single quote in double quotes) be a problem?

Copy link
Member Author

@ota-meshi ota-meshi Sep 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for checking this PR!
I added that test case and checked it's ok.

https://github.com/ota-meshi/svelte-eslint-parser/pull/220/files#diff-55b441b2965ba2c4cfd83a1cb1cf9ac88d9de2dd24ff63a171637ac71bbd1256R42-R47
https://github.com/ota-meshi/svelte-eslint-parser/pull/220/files#diff-4206eb687f56ab83406ab73e9e563465dd77239185a78bad5de3ca6b8b6bdc49R189-R229

return {
value: {
value: "",
quote,
start: startIndex,
end: index + 1,
},
index: index + 1,
};
}
const value: AttributeValueToken = {
value: valueFirstChar,
quote,
Expand Down
5 changes: 5 additions & 0 deletions tests/fixtures/parser/ast/script-tag-input.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<head>
<script type="text/javascript" id="" src="/some-script.js"></script>
<link href="/style.css" rel="stylesheet">
<script>console.log('foo')</script>
</head>
Loading