(feat) update imports for renames/moves files #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 26, 2020 11:35
- Bumping ts version speeds up rename files - Not refreshing the files will result in the ts service not noticing some updates which would create a bug where if you rename a file and rename it again, the ts service would have old files and rename would not update all locations.
Now that tsconfig is used, the ts service is many times faster because it only knows the files inside the test folder
|
I notice an issue. For some reason, sometime it would apply the edit to the old path. so vscode would open a new tab with unsaved changes on a deleted file and the moved file doesn't get updated. |
|
Good catch! I somehow have to tell the language service to update its document beforehand so he knows the old one no longer exists. |
added 2 commits
May 28, 2020 11:07
The language service might want to do edits to the old path, not the new path -> rewire it. If there is a better solution for this, please file a PR :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #111
This works, but it's really slow. It takes 30 seconds minimum to update the paths. The time is entirely spent in theUpdate: Bumping ts to version 3.9 did the trick. Luckily for us, the ts team did speed up that exact area drastically.getEditsForFileRenameof the ts language service. Is this always this slow or am I doing something wrong?I also did manage to speed up the tests quite a bit by adding a
tsconfig.jsonto the testfiles folder. Before that the ts services inside the tests did know about the whole project with all its ts files, which lead to the slow tests.