Skip to content

fix: add support for trailing slashes in typed routes #14065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 20, 2025
Merged

fix: add support for trailing slashes in typed routes #14065

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0096db2
fix: add support for trailing slashes in typed routes
yuki0418 Jul 27, 2025
433dd4a
Merge branch 'main' into fix/trailing-slashes-typed-routes
Rich-Harris Aug 20, 2025
dc85fde
fix merge
Rich-Harris Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/curvy-bugs-build.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

fix: add trailing slash pathname when generating typed routes
13 changes: 12 additions & 1 deletion packages/kit/src/core/sync/write_types/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,21 @@ export function write_all_types(config, manifest_data) {
dynamic_routes.push(route_type);

const pathname = remove_group_segments(route.id);
pathnames.add(`\`${replace_required_params(replace_optional_params(pathname))}\` & {}`);
const replaced_pathname = replace_required_params(replace_optional_params(pathname));
pathnames.add(`\`${replaced_pathname}\` & {}`);

if (pathname !== '/') {
Copy link
Contributor Author

@yuki0418 yuki0418 Jul 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to add trailing slash only when export const trailingSlash = 'always'; is in a file.
But I couldn't find a way to check it.

// Support trailing slash
pathnames.add(`\`${replaced_pathname + '/'}\` & {}`);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I just add a trailing slash to type Pathname because user would not enter Router Id in href.
Sorry if I'm wrong.

}
} else {
const pathname = remove_group_segments(route.id);
pathnames.add(s(pathname));

if (pathname !== '/') {
// Support trailing slash
pathnames.add(s(pathname + '/'));
}
}

/** @type {Map<string, boolean>} */
Expand Down
3 changes: 3 additions & 0 deletions packages/kit/src/core/sync/write_types/test/app-types/+page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,12 @@ declare let pathname: Pathname;
pathname = '/nope';
pathname = '/foo';
pathname = '/foo/1/2';
pathname = '/foo/';
pathname = '/foo/1/2/';

// Test layout groups
pathname = '/path-a';
pathname = '/path-a/';
// @ts-expect-error layout group names are NOT part of the pathname type
pathname = '/(group)/path-a';

Expand Down
Loading