Skip to content

fix: svelte should find other package on yarn pnp #12563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

fix: svelte should find other package on yarn pnp #12563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
37824ae
fix: yarn pnp shoulde work on node ^20.6.0
sunrabbit123 Aug 9, 2024
bda3b2e
chore: contains changeset
sunrabbit123 Aug 9, 2024
73fe079
fix: semver calculate
sunrabbit123 Aug 10, 2024
6ac5186
fix: redeclare resolve function semver range
sunrabbit123 Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/famous-colts-grin.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

fix: svelte should find other package on yarn pnp ([#12563](https://github.com/sveltejs/kit/pull/12563))
10 changes: 9 additions & 1 deletion packages/kit/src/utils/import.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,17 @@ import { pathToFileURL } from 'node:url';
* @param {string} dependency
*/
export function resolve_peer_dependency(dependency) {
const [major, minor] = process.versions.node.split('.').map(Number);
try {
const resolved = (() => {
if (major > 20 || (major === 20 && minor >= 6) || (major === 18 && minor >= 19)) {
// @ts-expect-error the types are wrong
return import.meta.resolve(dependency);
}
// @ts-expect-error the types are wrong
return imr.resolve(dependency, pathToFileURL(process.cwd() + '/dummy.js'));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want remove this, but i don't know side effect

})();
// @ts-expect-error the types are wrong
const resolved = imr.resolve(dependency, pathToFileURL(process.cwd() + '/dummy.js'));
return import(resolved);
} catch {
throw new Error(
Expand Down