chore: use context.filename and context.physicalFilename
#1174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 47aca08 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Try the Instant Preview in Online PlaygroundInstall the Instant Preview to Your LocalPublished Instant Preview Packages:
|
|
i'll open a 3rd PR to remove the file and the dependency entirely once this and #1173 are merged since we can do the same for |
baseballyama
approved these changes
Mar 31, 2025
Since we now require latest 8.x, all versions of ESLint we support have both `context.filename` and `context.physicalFilename`. In the old types, `physicalFilename` could be undefined but now will actually default to `filename` (so the type has also changed).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we now require latest 8.x, all versions of ESLint we support have both
context.filenameandcontext.physicalFilename.In the old types,
physicalFilenamecould be undefined but now will actually default tofilename(so the type has also changed).If #1173 lands first, this will have conflicts i'll resolve before we can merge.