-
Notifications
You must be signed in to change notification settings - Fork 1.5k
trying to make gemini live work with pipecat #674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
supermemory-app | 9465f57 | Commit Preview URL | Jan 16 2026, 08:13 PM |
How to use the Graphite Merge QueueAdd the label Main to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Code Review - Gemini Live Pipecat IntegrationSummaryThis PR adds support for speech-to-speech models (specifically Gemini Live) to the pipecat-sdk-python package by introducing transcription frame handling. The implementation looks solid overall, with a few considerations below. ✅ Positives
|
| static=profile["static"], | ||
| dynamic=profile["dynamic"], | ||
| search_results=memories_data["search_results"], | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The code uses dictionary-style access r["memory"] on search result objects, which expect attribute access like r.content. This will cause a TypeError.
Severity: CRITICAL
Suggested Fix
Change the dictionary-style access r["memory"] to attribute-style access. Based on usage in documentation and other parts of the codebase, the correct form is likely r.content. The line should be updated to search_results = [r.content for r in response.search_results.results].
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: packages/pipecat-sdk-python/src/supermemory_pipecat/service.py#L344
Potential issue: The list comprehension `[r["memory"] for r in
response.search_results.results]` uses dictionary-style indexing to access memory
content from search results. However, documentation and usage examples across the
codebase show that the search results are objects, not dictionaries. The correct way to
access the content is via an attribute, such as `r.content` or `r.memory`. This mismatch
will cause a `TypeError` whenever the memory retrieval process finds and attempts to
process search results, crashing the operation.
Did we get this right? 👍 / 👎 to inform future reviews.
PR Review: Gemini Live Speech-to-Speech SupportSummaryThis PR adds support for speech-to-speech models (specifically Gemini Live) by handling Code Quality ✅Good:
Issues: Security 🔒Good:
Logic & Implementation 🤔Issues Found:
Performance 🚀Good:
Minor concern:
Test Coverage 🧪Issue:
Recommendation:
Breaking Changes 📦None - This is additive functionality. Adding version 0.1.0 → 0.1.1 is appropriate for a minor feature addition. However, verify the VerdictApprove with minor concerns ✅ The implementation is solid, but address:
|

No description provided.