docs: clarify Facebook not supported for signInWithIdToke #1260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs: clarify Facebook not supported for signInWithIdToken in function docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies in the signInWithIdToken function docstring that only Google, Apple, Kakao, and Keycloak are supported as providers; Facebook is NOT supported.
What kind of change does this PR introduce?
Docs update (clarification)
What is the current behavior?
Docs do not specify which providers are actually supported for signInWithIdToken; Facebook is not supported but this is unclear.
Relevant issue: #1259
What is the new behavior?
Readers and developers will not be confused—supported providers are now explicitly listed in the docstring, preventing misuse.
Additional context
Inspected OAuthProvider enum and actual code—Facebook is not implemented as a provider for signInWithIdToken.