Skip to content

feat(gotrue): Remove client-side provider validation for signInWithIdToken #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

grdsdev
Copy link
Contributor

@grdsdev grdsdev commented Aug 12, 2025

Summary

  • Facebook is now supported as an OIDC provider.
  • Remove experimental annotation from signInWithIdToken method
  • Remove client-side validation restricting providers to Google, Apple, Kakao, and Keycloak
  • Backend will now handle provider validation, allowing for more flexible provider support

Test plan

  • Verify existing tests still pass
  • Test signInWithIdToken with previously restricted providers
  • Confirm backend properly handles unsupported providers

🤖 Generated with Claude Code

…Token

Remove experimental annotation and provider restrictions from signInWithIdToken method.
The client will no longer validate supported providers - this validation will be
handled by the backend, allowing for more flexible provider support.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@grdsdev grdsdev changed the title feat(gotrue): remove client-side provider validation for signInWithIdToken feat(gotrue): Remove client-side provider validation for signInWithIdToken Aug 12, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 16906177253

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 80.749%

Files with Coverage Reduction New Missed Lines %
packages/gotrue/lib/src/gotrue_client.dart 1 65.6%
Totals Coverage Status
Change from base Build 16305074338: 0.1%
Covered Lines: 3104
Relevant Lines: 3844

💛 - Coveralls

@grdsdev grdsdev merged commit e8d40d6 into main Aug 14, 2025
17 of 18 checks passed
@grdsdev grdsdev deleted the guilherme/clibs-294-supabase-flutter-remove-providers-check-for-the branch August 14, 2025 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants