fix: prevent race condition in async token refresh #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandarini
force-pushed
the
fix/async-token-refresh-race-condition
branch
from
dc11250 to
9c556eb
Compare
hf
reviewed
Oct 29, 2025
Comment on lines
+221
to
+226
| Promise.resolve().then(() => { | ||
| client.auth.getSession().catch(() => { | ||
| // Ignore errors - if session loading fails, the client is still usable | ||
| // and subsequent auth operations will handle the error appropriately | ||
| }); | ||
| }); |
Collaborator
There was a problem hiding this comment.
I'm a bit scared of this as it runs all the time when the server gets created, but without the ability to set cookies if that's needed
Contributor
Author
There was a problem hiding this comment.
@hf Yeah I agree, it's a slippery slope. I wonder if there's a better way to treat this, and not get that race condition issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Automatically initialize session on server client creation to trigger token refresh early in request lifecycle. This prevents race condition where refresh completes after response is sent, causing cookie errors. Also adds helpful error context before throwing if edge cases occur.
What is the current behavior?
Most possibly caused by token refresh.
What is the new behavior?
Initialize session to trigger token refresh early.