This repository was archived by the owner on Aug 22, 2025. It is now read-only.
Add sync functions #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pytests Throw errors instead of returning them
anand2312
suggested changes
Oct 23, 2023
supafunc/__init__.py
Outdated
There was a problem hiding this comment.
I don't really like the create_client functions tbh; what do you think about just not providing them? It's easy enough for the user to just import the client they want and instantiate it, the create_client functions don't really do much else either so it feels like bloat
There was a problem hiding this comment.
I think this should be removed too but this will be a breaking change and we should remove this in all the python libraries at the same time.
There was a problem hiding this comment.
I agree - we can add deprecation warnings to all of them now and remove them soon
Co-authored-by: Anand <[email protected]>
Co-authored-by: Anand <[email protected]>
anand2312
suggested changes
Oct 24, 2023
anand2312
reviewed
Oct 24, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
anand2312
approved these changes
Oct 25, 2023
This was referenced Oct 25, 2023
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Update with sync functions, added pytests and throw error messages instead of returning them.
What is the current behavior?
There are only async functions, no pytests and errors are returned
What is the new behavior?
We now have sync functions, pytests and errors are thrown
Additional context
Addresses #6