Skip to content

Conversation

jan-tennert
Copy link
Collaborator

What kind of change does this PR introduce?

Feature (closes #925)

What is the new behavior?

New standard headers providing OS name & version

@jan-tennert
Copy link
Collaborator Author

@grdsdev Should we distinguish between JS and WASM JS? Or combine them as "Browser"?

@grdsdev
Copy link
Contributor

grdsdev commented May 12, 2025

@grdsdev Should we distinguish between JS and WASM JS? Or combine them as "Browser"?

It is not right to consider WASM JS as browser, but I don't think there is an easy way of getting the platform running it, in this case is better to not send any value

@jan-tennert
Copy link
Collaborator Author

@grdsdev Should we distinguish between JS and WASM JS? Or combine them as "Browser"?

It is not right to consider WASM JS as browser, but I don't think there is an easy way of getting the platform running it, in this case is better to not send any value

Well both JS and WASM JS can run in the browser, but can also be server side, which we could check

@jan-tennert jan-tennert marked this pull request as ready for review May 28, 2025 21:45
@github-actions github-actions bot added the tests label May 28, 2025
@jan-tennert jan-tennert merged commit d75214c into master May 31, 2025
13 checks passed
@jan-tennert jan-tennert deleted the os-version branch May 31, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature request]: Send standard client headers on all requests

2 participants