fix: enhancement of postgres change handlers #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the handling of PostgreSQL changes, update channel naming conventions, and enhance testing configurations. The most important changes include the introduction of a new method for handling PostgreSQL changes, deprecations of older methods, and updates to test cases to reflect these new changes.
Enhancements to PostgreSQL Change Handling:
Realtime/Interfaces/IRealtimeChannel.cs: Added a new methodOnPostgresChangeto register and add PostgreSQL change handlers with various parameters.Realtime/RealtimeChannel.cs: Implemented theOnPostgresChangemethod and marked the olderAddPostgresChangeHandlerandRegistermethods as obsolete. [1] [2]Deprecations:
Realtime/Interfaces/IRealtimeClient.cs: Marked theChannelmethod with multiple parameters as obsolete, advising to use the simplerChannel(string channelName)method instead.Realtime/PostgresChanges/PostgresChangesOptions.cs: Deprecated theParametersproperty, indicating it will be removed in a future version.Channel Naming Conventions:
Realtime/Client.cs: Updated channel topic creation to ensure it starts with "realtime:".RealtimeTests/ChannelPostgresChangesTests.cs,RealtimeTests/ChannelTests.cs,RealtimeTests/ClientTests.cs) to use the new channel naming conventions (realtime:public:todos). [1] [2] [3]Testing Configurations:
.github/workflows/build-and-test.yml: Replaced commented-out steps with Supabase setup and start commands to streamline the build and test workflow.supabase/.gitignore: Added.branches,.temp, and.envto the.gitignorefile to exclude Supabase-related temporary files.These changes collectively enhance the functionality and maintainability of the codebase, particularly in handling PostgreSQL changes and improving testing workflows.