refactor: config codegen #598
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psteinroe
commented
Nov 4, 2025
| use crate::{Rules, linter::RuleGroup}; | ||
|
|
||
| #[derive(Clone, Copy, Debug, Eq, PartialEq, Hash)] | ||
| pub enum RuleSelector { |
There was a problem hiding this comment.
this will be made more generic in a future pr
- Fix unresolved import from analyser to linter in workspace tests - Remove empty line after outer attribute in diagnostics - Apply clippy suggestions for cleaner code 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Add ORDER BY clause to roles query for deterministic results - Update role completion tests to expect all default Supabase roles - Create helper function to centralize expected roles list - Update SQLx offline cache for modified query 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rewires the pgls_configuration crate alongside its codegen xtask as a preparation for new lint tools (
splinterandpglinter). its all the same as before, I just moved things in the config crate around, and the xtask is geared towards tools vs just the analyser. common primitives are now in/rules/, and we generate one dir per tool (linter,splinter,pglinter) etc.the codegen refactoring was initially written by me but completed by Claude. Everything outside of xtask/ was done by hand or is re-generated.
TODO (in follow-up prs)
pgls_analysercrate topgls_linterpgls_pglinter,pgls_splinterandpgls_assistsand integrate them withpgls_analyseto allow aRuleVisitorto collect the metadataAnalysera bit.