fix: context-aware named param conversion

[psteinroe]

we were blindly converting named parameters to positional parameters. but the latter is only valid as a literal, and not as an identifier.

statements like

grant usage on schema public, app_public, app_hidden to :DB_ROLE;

are not valid when converted to

grant usage on schema public, app_public, app_hidden to $1;

i went a bit back and forth on this and decided the easiest way to fix this is to convert to identifiers like a if the previous non-trivia token is one of a set list of tokens. We will probably have a bunch of edge cases here but fixing them should be as easy as adding a keyword to the list.

now, we convert to

grant usage on schema public, app_public, app_hidden to a;

closes #510

[juleswritescode]

nice!

So the typechecker doesn't properly check whether a role exists?
I would've expected it to complain about the "missing role a"

[juleswritescode]

i love me a good recursion

[psteinroe]

das kam sogar ohne Claude 😂

[juleswritescode]

das war n bug nehm ich an?

[psteinroe]

Ja, allerdings kein wichtiger für die Statement Splitter Logik deshalb kam es nie raus

[psteinroe]

nice!

So the typechecker doesn't properly check whether a role exists?

I would've expected it to complain about the "missing role a"

The typechecker just runs on DML statements and such replacement are less of an issue there. but at some point someone will report it too I guess. If that happens, we can find another solution for it. 😅👍🏼