feat(completions): add textDocument/completion request to LSP + workspace handlers

[juleswritescode]

This PR adds the textDocument/completion capability to the lsp server 🎉

• added completion to the lsp-server's ServerCapabilities
• Removed the println statements from the workspace, since they were writing to stdout and thus led to crashes for the lsp-client
• introduced a couple of tracing macros to the lsp server handlers, changed log levels to "info" for methods that happen infrequently (shutdown, initialize etc.)
• upgraded the vscode-languageclient to 9.0.1, which made for better log output

The autocompletions aren't stable right now – completions are sometimes gathered for the wrong statement, and sometimes, the corresponding statement isn't even found. I will fix this in a separate PR 👍

Besides, I wasn't able to start the pg_cli lsp-proxy with the VSCode extension. I'll fix this in a separate PR, too.

[psteinroe]

a few nits, overall lgtm!

[juleswritescode]

@psteinroe Update: Replacing the VsCode Extension's OutputChannel to a LogOutputChannel persists the logs, which is quite nice...

If you look at the output, you can see that the returned "JSON" matches our println statements.

I guess stdout is sent directly to the client?

[psteinroe]

@juleswritescode the cli (and the lsp proxy) writes the output also to a logfile. I am not sure it's the same logs as the lsp client but it helps me debugging a lot. You can find the path to the directory in the pg_fs crate. I also have a script that automatically opens the latest log file (rotated every day, new logfile every hour) and subscribes to it. I can send it over later.

[psteinroe]

awesome!! left a few comments :)

[juleswritescode]

the cli (and the lsp proxy) writes the output also to a logfile. I am not sure it's the same logs as the lsp client but it helps me debugging a lot. You can find the path to the directory in the pg_fs crate. I also have a script that automatically opens the latest log file (rotated every day, new logfile every hour) and subscribes to it. I can send it over later.

Nice! That's useful. I'm still using the pglsp.log for server logs.
The client logs are different though, those are output by the vscode-languageclient/node#LanguageClient, which was the one throwing the Content-Length error.

Still, please send over the script 🙌

[juleswritescode]

@psteinroe I cleaned up the PR, wrote a description and it should now be reviewable 👍
I'll address the other issues we talked about in separate PRs.

[psteinroe]

the cli (and the lsp proxy) writes the output also to a logfile. I am not sure it's the same logs as the lsp client but it helps me debugging a lot. You can find the path to the directory in the pg_fs crate. I also have a script that automatically opens the latest log file (rotated every day, new logfile every hour) and subscribes to it. I can send it over later.

Nice! That's useful. I'm still using the pglsp.log for server logs. The client logs are different though, those are output by the vscode-languageclient/node#LanguageClient, which was the one throwing the Content-Length error.

Still, please send over the script 🙌

Do not forget to update the username (psteinroe)!

# Open latest logfile for the lsp
function open_lsp_log() {
  latest_file=$(ls -t /Users/psteinroe/Library/Caches/dev.supabase-community.pglsp/pglsp-logs | head -n 1)
  if [ -n "$latest_file" ]; then
    tail -f "/Users/psteinroe/Library/Caches/dev.supabase-community.pglsp/pglsp-logs/$latest_file"
  else
    echo 'No log files found'
  fi
}