naive statement splitter #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
juleswritescode
left a comment
juleswritescode
left a comment
There was a problem hiding this comment.
Wow, this is so much simpler than the previous implementation. I love it.
| // delete(p); | ||
| } | ||
| t => { | ||
| panic!("stmt: Unknown token {:?}", t); |
Collaborator
There was a problem hiding this comment.
Suggested change
| panic!("stmt: Unknown token {:?}", t); | |
| panic!("stmt: Unknown start token {:?}", t); |
Collaborator
Author
|
@juleswritescode I refactored the parser to work with an index into the vector. this comes with a few benefits:
edit: added a little test helper |
Collaborator
Author
|
@juleswritescode I think this is ready now. dml statements should work good enough. |
juleswritescode
approved these changes
Oct 21, 2024
| @@ -1,12 +0,0 @@ | |||
| brin | |||
| r.start(), | ||
| r.end() + TextSize::from(self.diff_size()), | ||
| ); | ||
| *r = TextRange::new(r.start(), r.end() + self.diff_size()); |
Collaborator
There was a problem hiding this comment.
hmm, strange that there's no method on the type for increasing the range 🤷
Comment on lines
+49
to
+51
| statement_ranges: text.as_ref().map_or_else(Vec::new, |f| { | ||
| pg_statement_splitter::split(f).ranges.to_vec() | ||
| }), |
Collaborator
There was a problem hiding this comment.
pretty cool changes here in the file!
Comment on lines
+181
to
+184
| self.errors.push(SyntaxError::new( | ||
| format!("Expected {:#?}", kind), | ||
| self.peek().span, | ||
| )); |
Collaborator
There was a problem hiding this comment.
very nice! much cleaner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
naive attempt at splitting statements.
implements the splitter as a simple Pratt Parser. The approach now is the opposite of what I tried before: Instead of assuming it works perfectly as long as we cover all possible edge cases, we assume it does not work at all. We want to make all important cases work (mostly DML, a few DDL statements), while asking the user to fallback to a double newline if they are seeing weird things coming from the lsp.