Skip to content

bugfix: selecting-with-filter-on-empty-table #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

bugfix: selecting-with-filter-on-empty-table #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6fc4938
fix: selecting item with filter in empty table
jwelmac Mar 16, 2025
828178f
test: add case for selecting after deleting all items
jwelmac Mar 16, 2025
f850213
test: move test to basic CRUD tests
jwelmac Mar 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/mock_supabase_http_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,7 @@ class MockSupabaseHttpClient extends BaseClient {
}).toList();
} else if (key.contains('!inner')) {
// referenced table filtering with !inner
} else {
} else if (returningRows.isNotEmpty) {
// Regular filtering on the top level table
final filter = FilterParser.parseFilter(
columnName: key,
Expand Down
10 changes: 10 additions & 0 deletions test/mock_supabase_http_client_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,16 @@ void main() {
expect(posts.length, 0);
});

test('Select after deleting all items', () async {
// Insert an item
await mockSupabase
.from('posts')
.insert({'id': 1, 'title': 'To be deleted'});
await mockSupabase.from('posts').delete().eq('id', 1);
final posts = await mockSupabase.from('posts').select().eq('id', 1);
expect(posts.length, 0);
});

test('Select all columns', () async {
// Test selecting all records
await mockSupabase.from('posts').insert([
Expand Down