♿(frontend) add correct attributes to decorative and interactive icons #1255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ovgodd
force-pushed
the
fix/897-decorative-icons
branch
from
a022a32 to
bc4ecdb
Compare
Ovgodd
force-pushed
the
fix/897-decorative-icons
branch
6 times, most recently
from
1b41461 to
c3176d6
Compare
Add aria-hidden and aria-label to improve screen reader accessibility Signed-off-by: Cyril <[email protected]>
Ovgodd
force-pushed
the
fix/897-decorative-icons
branch
from
c3176d6 to
99d674c
Compare
selectors were updated to stabilize and fix the failing e2e tests Signed-off-by: Cyril <[email protected]>
Closed
AntoLC
approved these changes
Aug 5, 2025
|
|
|
I love that feeling ahah |
AntoLC
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Enhance accessibility for screen reader users by:
issue : 897
Proposal
aria-hidden="true"on decorative icons to prevent screen readers from announcing them unnecessarilyaria-labelon icon-only buttons (e.g., Home, Search) to describe their purposeTitlecomponent to accept aheadingLevelprop for semantic flexibility<h1>instead of<h2>, as it represents the main heading of the application"Back to homepage"and"Search docs"in all supported locales