feat: don't overwrite flutter if correct version already present #359
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the PR. If I understand correctly, this adds a new |
|
Nope the |
bartekpacia
reviewed
Nov 3, 2025
Comment on lines
+116
to
+121
| if [ -d "${{ steps.flutter-action.outputs.CACHE-PATH }}" ]; then | ||
| echo "Cache path already exists, skipping cache step." | ||
| echo "flutter-action-cache-exists=true" >> "$GITHUB_OUTPUT" | ||
| else | ||
| echo "flutter-action-cache-exists=false" >> "$GITHUB_OUTPUT" | ||
| fi |
There was a problem hiding this comment.
Instead of setting an env var, let's add a new value to outputs of this action (starting at line 54 in this file).
Then please also update the README so that others can learn about this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a simple one to make my small runs on self hosted runners go faster.
CACHE_PATH includes the version so we only need to check that. The only concern would be if they set their own cache path