Makes getExampleFilename case insensitive #482
Conversation
Codecov Report
@@ Coverage Diff @@
## master #482 +/- ##
==========================================
+ Coverage 94.35% 94.39% +0.04%
==========================================
Files 96 96
Lines 1258 1285 +27
Branches 273 279 +6
==========================================
+ Hits 1187 1213 +26
- Misses 68 69 +1
Partials 3 3
Continue to review full report at Codecov.
|
|
Thanks for the pull request @verkholantsev! We already have an PR for that — #440 but I’m not sure if @dotcs is going to finish it. Please take a look at the comments there because your implementation has similar issues that I mentioned in the review ;-) |
|
I think we should clean the cache on code updates otherwise it won’t work when you add new files when Styleguidist is running. But better to test it to make sure how exactly it works ;-) |
|
@sapegin You are right, this implementation of cache breaks files watching in live server mode. What way of implementation do you think is the best? Function
I've got an idea, but I think it is quite dirty:
In this case there will no need to pass some parameters to |
|
It should be enough to reset cache just in styleguide-loader I think. |
|
My experiments are failed, I'm closing this PR. |
## New features ### Copy pathline to clipboard button  (#485, #471 by @SaraVieira) ### Easier way to override style guide React components New config option `styleguideComponents` to override React components used to render a style guide. ```javascript module.exports = { styleguideComponents: { Logo: path.join(__dirname, 'styleguide/components/Logo'), StyleGuideRenderer: path.join(__dirname, 'styleguide/components/StyleGuide'), }, }; ``` (#504) ### Customizable logging New `logger` option: ```javascript module.exports = { logger: { // One of: info, debug, warn // Suppress messages info: () => {}, // Override display function warn: message => console.warn(`NOOOOOO: ${message}`), }, }; ``` (#472, #510) ## Bug fixes * Allow `devServer.watchConfig` to be configured, this also means Vagrant is now supported (#515, #516 by @esphen) * Default `getExampleFilename` should be case-insensitive (#423, #460, #440, #482) * Allow dynamic JSS styles * Isolate search placeholder styles (#509, #491 by @n1313)
3 participants
Current implementation of
getExampleFilename()works in different way on Linux (case sensitive filesystem) and OS X (case insensitive filesystem). This pull request fixes this issue.