Fix: Fix site links for adblock users #1651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Thank you for merging! This is the first time I sent a PR to an open source project, so I'm super excited about this working out 🌟 |
Collaborator
|
🎉 This PR is included in version 11.0.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Dec 25, 2022
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using e.g. uBlock Origin, navigation in the styleguidist documentation is broken. This is because in that case "window.goatcounter" is undefined. I added a check that assures, goatcounter.count will only be called if goatcounter is defined. This way clicking on links and navigating the documentation still works when goatcounter is blocked.