-
Notifications
You must be signed in to change notification settings - Fork 258
Resolve issue with first displayName always being used #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,9 @@ | ||
name: Node.js Package | ||
|
||
on: | ||
push: | ||
branches: | ||
- '**' | ||
release: | ||
types: [created] | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
import * as React from 'react'; | ||
|
||
interface ButtonProps | ||
extends Omit<React.ButtonHTMLAttributes<HTMLButtonElement>, 'type'> {} | ||
|
||
export const Button = React.forwardRef<HTMLButtonElement, ButtonProps>( | ||
(props, ref) => <button {...props} ref={ref} type="button" /> | ||
); | ||
|
||
Button.displayName = 'First'; | ||
|
||
export const SubmitButton = React.forwardRef<HTMLButtonElement, ButtonProps>( | ||
(props, ref) => <button {...props} ref={ref} type="submit" /> | ||
); | ||
|
||
SubmitButton.displayName = 'Second'; | ||
|
||
export const ResetButton = React.forwardRef<HTMLButtonElement, ButtonProps>( | ||
(props, ref) => <button {...props} ref={ref} type="reset" /> | ||
); | ||
|
||
ResetButton.displayName = 'Third'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import * as React from 'react'; | ||
|
||
interface ButtonProps | ||
extends Omit<React.ButtonHTMLAttributes<HTMLButtonElement>, 'type'> {} | ||
|
||
export const Button1 = React.forwardRef<HTMLButtonElement, ButtonProps>( | ||
(props, ref) => <button {...props} ref={ref} type="button" /> | ||
); | ||
Button1.displayName = 'First'; | ||
|
||
export const NoExplicitDisplayName1 = (props: any) => <div>Some text</div>; | ||
|
||
export const Button2 = (props: ButtonProps) => ( | ||
<button {...props} type="button" /> | ||
); | ||
Button2.displayName = 'Second'; | ||
|
||
export const NoExplicitDisplayName2 = (props: any) => <div>Some more text</div>; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
import * as React from 'react'; | ||
|
||
interface ButtonProps | ||
extends Omit<React.ButtonHTMLAttributes<HTMLButtonElement>, 'type'> {} | ||
|
||
export const Button = (props: ButtonProps) => ( | ||
<button {...props} type="button" /> | ||
); | ||
export const SubmitButton = (props: ButtonProps) => ( | ||
<button {...props} type="submit" /> | ||
); | ||
export const ResetButton = (props: ButtonProps) => ( | ||
<button {...props} type="reset" /> | ||
); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't certain about this, but it did seem to resolve the one failing test I was dealing with.
Specifically: 'should be taken from stateless component
displayName
property (using default export) even if file name doesn't match'There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pvasek @jesstelford curious on any input here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This produced false-negatives in my scenario. I presume because there is only one with
displayName
, it was ignoring the others.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AMoo-Miki If you log
exports
there, what's the output?