Skip to content

Conversation

@joehiggi1758
Copy link
Contributor

Pull Request Checklist

Below is a simple checklist but please do not hesitate to ask for assistance!

  • Fork, clone, and checkout the newest version of the code
  • Create a new branch
  • Make necessary code changes
  • Install black (i.e., python -m pip install black or conda install -c conda-forge black)
  • Install flake8 (i.e., python -m pip install flake8 or conda install -c conda-forge flake8)
  • Install pytest-cov (i.e., python -m pip install pytest-cov or conda install -c conda-forge pytest-cov)
  • Run black . in the root stumpy directory
  • Run flake8 . in the root stumpy directory
  • Run ./setup.sh && ./test.sh in the root stumpy directory
  • Reference a Github issue (and create one if one doesn't already exist)

@joehiggi1758 joehiggi1758 requested a review from seanlaw as a code owner August 15, 2024 21:04
@codecov
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.32%. Comparing base (79096a8) to head (dad4f76).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1026   +/-   ##
=======================================
  Coverage   97.32%   97.32%           
=======================================
  Files          89       89           
  Lines       14964    14964           
=======================================
  Hits        14563    14563           
  Misses        401      401           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seanlaw seanlaw changed the title [#1010] fixed pull request checklist Fixed #1010 pull request checklist Aug 16, 2024
Copy link
Contributor

@seanlaw seanlaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good @joehiggi1758. Is this ready to be merged?

@joehiggi1758
Copy link
Contributor Author

It is! @seanlaw

@seanlaw seanlaw merged commit e271570 into stumpy-dev:main Aug 16, 2024
@seanlaw
Copy link
Contributor

seanlaw commented Aug 16, 2024

Thank you @joehiggi1758! 🎉

@joehiggi1758
Copy link
Contributor Author

Many thanks for the opportunity @seanlaw !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants