Add CPPLINT static code analysis #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot_tools The file was copied from commit ebe839b6bfc3e9276b8d1e42a0d6e830bb04899e
dsookhoo
added a commit
to rlunatrax/libheif
that referenced
this pull request
May 9, 2022
dsookhoo
added a commit
to rlunatrax/libheif
that referenced
this pull request
May 11, 2022
* GitHub Test onto ds/NFE-150 * Added comments as notes to help me understand the code better * Added debug function in libheif, added comments * Reverted to original version * heif_api_structs.h - reverted to original version * libheif/bistream.h reverted to original version * libheif/box.h reverted to original version * Added function: get_heif_file(). This allows the private heif_file object to be extracted from the heif_context * libheif/heif_file.h - The HeifFile class has a private vector of boxes called 'm_top_level_boxes'. The function 'get_top_level_boxes()' was added to retrieve that vector. * examples/heif_convert.cc - Reverted to original version * examples/heif_convert.cc - Reverted to original version (attempt #2) * examples/heif_convert.cc - Reverted to original version (attempt strukturag#3) * heif_box.cc is a file that recently created and no longer need * Delete heif_box.cc This file was recently created by me and is no longer needed. * This example has been completely gutted, leaving only the essential code for converting a heif to a jpg * added additional executable examples files for testing * Removed all-caps comments, removed People's names, Error handling is now std::cerr (rather than mixing in fprintf(stderr, ...), created functions: create_heif_file() & printBoxes(), replaced complicated variables with 'auto'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now only enable
build/include_what_you_useto make sure necessary headers get included. The checks will be extended in the future to ensure a consistent style.Also contains a pre-commit hook (installed by
autogen.sh) to check files before they get committed.