Skip to content

Various API changes #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

Various API changes #2

wants to merge 11 commits into from

Conversation

@fancycode
Copy link
Member

@fancycode fancycode commented Jan 5, 2018

  • All functions that can potentially fail now return a heif_error.
  • Decoding plugins can also return errors in case something fails.
  • The libde265 decoder only uses the public API.

@fancycode
Various API changes:
4ce7edc 
- All functions that can potentially fail now return a "heif_error".
- Decoding plugins can also return errors in case something fails.
- The libde265 decoder only uses the public API.
@fancycode fancycode requested a review from farindk January 5, 2018 10:00
@fancycode
Copy link
Member Author

fancycode commented Jan 5, 2018

I'm thinking we should even change all functions to return a heif_error, even if they just return a number like heif_context_get_number_of_images. This allows returning an error if the passed pointers are not valid.

@fancycode
Copy link
Member Author

fancycode commented Jan 5, 2018

Manually rebase and merged by @farindk

@fancycode fancycode closed this Jan 5, 2018
@fancycode fancycode deleted the api-changes branch January 5, 2018 12:42
@lzzcg lzzcg mentioned this pull request Jun 19, 2018
Closed
@lvmodan lvmodan mentioned this pull request May 11, 2020
Closed
@zsuhoo zsuhoo mentioned this pull request Sep 11, 2023
Closed
@xiaoxiaoafeifei xiaoxiaoafeifei mentioned this pull request Dec 14, 2023
Closed
@xiaoxiaoafeifei xiaoxiaoafeifei mentioned this pull request Dec 21, 2023
Closed
@bobfriesenhahn bobfriesenhahn mentioned this pull request Sep 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@farindk farindk Awaiting requested review from farindk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fancycode @farindk