Skip to content

Conversation

lehni
Copy link
Contributor

@lehni lehni commented Jul 24, 2017

Description

This PR allows boot scripts to be defined in the ES6 async fashion, without the need for passing callbacks:

module.exports = async function(app) {
   ...
};

Related issues

  • None

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

@slnode
Copy link

slnode commented Jul 24, 2017

Can one of the admins verify this patch?

2 similar comments
@slnode
Copy link

slnode commented Jul 24, 2017

Can one of the admins verify this patch?

@slnode
Copy link

slnode commented Jul 24, 2017

Can one of the admins verify this patch?

@slnode
Copy link

slnode commented Jul 24, 2017

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@bajtos
Copy link
Member

bajtos commented Jul 26, 2017

@raymondfeng @davidcheung please review. You may want to consider my comments in #252 too.

@bajtos
Copy link
Member

bajtos commented Jul 26, 2017

@slnode ok to test

@bajtos
Copy link
Member

bajtos commented Aug 11, 2017

Hi @lehni, could you please forward-port the changes from #252 that you made as part of the review process?

@lehni
Copy link
Contributor Author

lehni commented Aug 15, 2017

@bajtos I am back from my holiday, will look into these pending things now!

@bajtos
Copy link
Member

bajtos commented Aug 15, 2017

@lehni sounds good, welcome back! :)

@lehni
Copy link
Contributor Author

lehni commented Aug 18, 2017

@bajtos this PR now contains the changes of both #252 and #260 ported over to the master branch.

Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's give some time for @raymondfeng to review too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants