-
Notifications
You must be signed in to change notification settings - Fork 72
Add support for ES6 style async boot scripts #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ES6 style async boot scripts #253
Conversation
Can one of the admins verify this patch? |
2 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
@raymondfeng @davidcheung please review. You may want to consider my comments in #252 too. |
@slnode ok to test |
@bajtos I am back from my holiday, will look into these pending things now! |
@lehni sounds good, welcome back! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's give some time for @raymondfeng to review too.
Description
This PR allows boot scripts to be defined in the ES6 async fashion, without the need for passing callbacks:
Related issues
Checklist
guide