Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 28, 2025

Prevents commits with stale generated code or unformatted files by enforcing make codegen lint in CI.

Changes

  • New codegen_check job in test.yml: Runs make codegen lint on Python 3.10 and fails if any files are modified or untracked, ensuring sync library stays current with async source
  • Updated job dependencies: test_quick now depends on codegen_check to gate all tests on codegen compliance
  • Documentation updates: Added CI enforcement notice to AGENTS.md and DEVELOPING.md

Implementation

The check uses:

git diff --exit-code                        # Detect modified files
git ls-files --others --exclude-standard    # Detect untracked files

Both must return empty for the build to pass.

Original prompt

This section details on the original issue you should resolve

<issue_title>Run codgen build step</issue_title>
<issue_description>We should run make codegen lint as part of the build and if anything changes fail the build
</issue_description>

Comments on the Issue (you are @copilot in this section)

@strawgate @claude please make a PR

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 28, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch copilot/run-codegen-build-step

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

Copilot AI changed the title [WIP] Add codegen build step to fail on changes Add CI enforcement for codegen and lint compliance Oct 28, 2025
Copilot AI requested a review from strawgate October 28, 2025 18:32
Copilot finished work on behalf of strawgate October 28, 2025 18:32
@strawgate strawgate marked this pull request as ready for review October 28, 2025 18:58
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

@strawgate strawgate merged commit 131f11d into main Oct 28, 2025
78 of 79 checks passed
@strawgate strawgate deleted the copilot/run-codegen-build-step branch October 28, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run codgen build step

2 participants