Skip to content

Conversation

@mulkieran
Copy link
Member

@mulkieran mulkieran commented Oct 22, 2025

Related stratis-storage/project#805

Summary by CodeRabbit

  • Chores
    • Updated development container image to a newer version
    • Minimum Python version requirement increased to 3.12

@mulkieran mulkieran self-assigned this Oct 22, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 22, 2025

Walkthrough

The CI workflow container image was updated from Fedora 41 to 42 in two jobs, and a minimum Python version requirement of >=3.12 was added to setup.cfg, establishing baseline compatibility constraints.

Changes

Cohort / File(s) Summary
CI container version
.github/workflows/main.yml
Updated container image tag from fedora:41 to fedora:42 in development_environment_checks and lowest_supported_python jobs
Python version constraint
setup.cfg
Added python_requires = >=3.12 under [options] section to enforce minimum Python version requirement

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 From Fedora's prior nest to version forty-two we hop,
While Python 3.12 becomes the floor we cannot drop,
Simple constraints and container leaps—the changes help align,
Dependencies and images dance, all by design!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "Increase CURRENT DEVELOPMENT ENVIRONMENT to Fedora 42" clearly addresses the primary change in the changeset: updating the container image from Fedora 41 to Fedora 42 in the workflow files. The title is specific, concise, and directly corresponds to the stated PR objective. While the changeset also includes an addition of python_requires = >=3.12 in setup.cfg, this appears to be a secondary or related change, and the instructions acknowledge that a title does not need to cover every detail of the changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 455edae and e0a1fa3.

📒 Files selected for processing (2)
  • .github/workflows/main.yml (2 hunks)
  • setup.cfg (1 hunks)
🔇 Additional comments (3)
setup.cfg (1)

25-25: LGTM! Python version constraint aligns with CI upgrade.

The addition of python_requires = >=3.12 is appropriate, as Fedora 42 ships with Python 3.13 as the default system Python. This constraint ensures compatibility with the updated development environment while still allowing usage with Python 3.12, which is tested in the lowest_supported_python CI job.

Note: This is a breaking change for users on Python versions below 3.12.

.github/workflows/main.yml (2)

33-33: LGTM! Container image update is valid.

The update to fedora:42 is appropriate, as Fedora 42 has been released and aligns with the PR objective to update the development environment.


53-66: LGTM! Container update and job configuration are consistent.

The update to fedora:42 is appropriate. The lowest_supported_python job correctly tests Python 3.12 (lines 55-66), which aligns with the new python_requires = >=3.12 constraint added to setup.cfg.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mulkieran mulkieran moved this to In Review in 2025October Oct 22, 2025
@mulkieran mulkieran merged commit 5833695 into stratis-storage:master Oct 22, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in 2025October Oct 22, 2025
@mulkieran mulkieran deleted the issue_project_805 branch October 22, 2025 01:48
@mulkieran mulkieran moved this from Done to Done(3) in 2025October Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done(3)

Development

Successfully merging this pull request may close these issues.

1 participant