fixed bug of hanging CompletableFutures of requests
#7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalaninja
reviewed
Jan 31, 2022
transport/src/main/java/com/strategyobject/substrateclient/transport/ws/WsProvider.java
Outdated
Show resolved
Hide resolved
…WsProvider::send`) - GC collected them because they didn't have strong references instead of using `ReferenceQueue` for cleaning handlers currently is used `ScheduledExecutorService` that schedules completing futures with `TimeoutException` and removing corresponding handlers
vnabiev
force-pushed
the
fix/gc-collected-handlers
branch
from
f3d85fd to
196fa63
Compare
kalaninja
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(when calling
WsProvider::send) - GC collected them because they didn't have strong referencesinstead of using
ReferenceQueuefor cleaning handlers currently is usedScheduledExecutorServicethat schedules completing futures withTimeoutExceptionand removing corresponding handlers