Events support #27
Merged
Events support #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalaninja
force-pushed
the
feature/events
branch
from
0633cfb to
8ee05e4
Compare
vnabiev
reviewed
Aug 2, 2022
crypto/src/main/java/com/strategyobject/substrateclient/crypto/Hasher.java
Outdated
Show resolved
Hide resolved
vnabiev
reviewed
Aug 2, 2022
| EventRegistry eventRegistry) { | ||
| val registry = new ScaleReaderRegistry(); | ||
| registry.registerAnnotatedFrom(PREFIX); | ||
| registry.register(new AccountDataReader(registry), System.AccountData.class, AccountData.class); |
Collaborator
There was a problem hiding this comment.
Could it be registered automatically?
Contributor
Author
There was a problem hiding this comment.
no, unless write a custom scale reader.
kalaninja
force-pushed
the
feature/events
branch
from
8ee05e4 to
7922673
Compare
vnabiev
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.