Unify bedrock & openai client creation for integ tests #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to better share code between browser and node integ tests, use a single implementation for creating clients and inside of the factory methods, do the conditional check for what environment we're running in. As part of this I refactored the setup to take advantage of vitest features of having the global setup inject data into the running tests - including whether we're running in the browser and if we're running in CI/CD.
zastrowm
changed the title
zastrowm
had a problem deploying
to
auto-approve
GitHub Actions
Failure
zastrowm
had a problem deploying
to
auto-approve
GitHub Actions
Failure
zastrowm
had a problem deploying
to
auto-approve
GitHub Actions
Failure
zastrowm
had a problem deploying
to
auto-approve
GitHub Actions
Failure
zastrowm
force-pushed
the
unify_client_creation
branch
from
3e822d0 to
acd1d25
Compare
zastrowm
had a problem deploying
to
auto-approve
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to better share code between browser and node integ tests, use a single implementation for creating clients. We accomplish this by taking advantage of vitest's global-setup which can pass/provide information to the tests regardless of what environment they're running in - we thus provide the credentials in global setup to the tests, which can then access the credentials in both environments.
Per the last PR (#337), I also unified the skipping & logic of creating clients making it much more standard how we'll write tests going forward.
Notes
__fixtures__folder for better code organizationFollow-up
A follow-up PR is planned to run more tests in both the browser & node; this gets us one step closer