Move vended_tools under src #327
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Consolidate all source code under the
srcdirectory for better organization.This moves vended tools under
src/vended-toolskeeping thevended_toolsexport for customers & backwards compatibility. I updated our eslint config to ensure that nothing outside of vended_tools references our vended_tools.I named it
src/vended-toolsinstead ofsrc/vended_toolsbecause it matches our other folders likeconversation-manager(IMHO dashes are more common/better for JS projects). Externally it's still vended_tools - I have/had a plan to migrate to vended-tools there as well, but want to discuss with the team first.Testing
As part of this change, I added code to our test:package to ensure that consumers can access these tools. The test(s) pass both before & after this change.
We also now export the
Toolclass; it was previously a type only export, but that was a left over artifact from whenToolwas interface and was never updated when we made it a base class.Related Issues
Documentation PR
Type of Change
Refactor
Testing
How have you tested the change?
npm run checkChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.